[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pci: add romsize property

From: Peter Xu
Subject: Re: [PATCH] pci: add romsize property
Date: Tue, 19 Jan 2021 11:31:23 -0500

On Fri, Dec 18, 2020 at 06:54:57PM +0000, Dr. David Alan Gilbert wrote:
> * Paolo Bonzini (pbonzini@redhat.com) wrote:
> > This property can be useful for distros to set up known-good ROM sizes for
> > migration purposes.  The VM will fail to start if the ROM is too large,
> > and migration compatibility will not be broken if the ROM is too small.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> I suspect something breaks horribly if you set this to the 4GB that the
> UINT32 would allow.
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Indeed, but we do have lots of restrictions (IIUC) in qemu cmdline that it
won't really work if we don't specify things correctly, so I won't worry it too
much, since I assumed qemu cmdline users are advanced users, always. :)

Reviewed-by: Peter Xu <peterx@redhat.com>

Peter Xu

reply via email to

[Prev in Thread] Current Thread [Next in Thread]