[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] qmp: remove deprecated "change" command
From: |
Eric Blake |
Subject: |
Re: [PATCH 2/3] qmp: remove deprecated "change" command |
Date: |
Wed, 20 Jan 2021 09:31:39 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/20/21 8:42 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> docs/system/deprecated.rst | 5 ----
> docs/system/removed-features.rst | 5 ++++
> monitor/qmp-cmds.c | 51 --------------------------------
> qapi/misc.json | 49 ------------------------------
> 4 files changed, 5 insertions(+), 105 deletions(-)
>
> -``change`` (since 2.5.0)
> -''''''''''''''''''''''''
> -
> -Use ``blockdev-change-medium`` or ``change-vnc-password`` instead.
We didn't document a fallback for changing the vnc listener...
> +++ b/docs/system/removed-features.rst
> @@ -53,6 +53,11 @@ are automatically loaded from qcow2 images.
> Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See
> documentation of ``query-hotpluggable-cpus`` for additional details.
>
> +``change`` (removed in 6.0)
> +'''''''''''''''''''''''''''
> +
> +Use ``blockdev-change-medium`` or ``change-vnc-password`` instead.
...and still don't,...
> -static void qmp_change_vnc(const char *target, bool has_arg, const char *arg,
> - Error **errp)
> -{
> - if (strcmp(target, "passwd") == 0 || strcmp(target, "password") == 0) {
> - if (!has_arg) {
> - error_setg(errp, QERR_MISSING_PARAMETER, "password");
> - } else {
> - qmp_change_vnc_password(arg, errp);
> - }
> - } else {
> - qmp_change_vnc_listen(target, errp);
...and now we're entirely removing that QMP ability, without
deprecation. Is that intended?
> +++ b/qapi/misc.json
> @@ -238,55 +238,6 @@
> 'returns': 'str',
> 'features': [ 'savevm-monitor-nodes' ] }
>
> -##
> -# @change:
> -#
> -# This command is multiple commands multiplexed together.
> -#
> -# @device: This is normally the name of a block device but it may also be
> 'vnc'.
> -# when it's 'vnc', then sub command depends on @target
> -#
> -# @target: If @device is a block device, then this is the new filename.
> -# If @device is 'vnc', then if the value 'password' selects the vnc
> -# change password command. Otherwise, this specifies a new server
> URI
> -# address to listen to for VNC connections.
That is, I'm wondering if we should be adding a change-vnc-listener QMP
command, and extending the deprecation for 2 more releases to allow this
final use of 'change vnc' to still work. Or are we really at the point
where we have no known users?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org