[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: Declare have_virtfs_proxy_helper in main meson.build

From: Paolo Bonzini
Subject: Re: [PATCH] meson: Declare have_virtfs_proxy_helper in main meson.build
Date: Wed, 20 Jan 2021 17:56:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 20/01/21 16:15, Philippe Mathieu-Daudé wrote:
have_virtfs_proxy_helper is used from docs/meson.build, and can be
not declared when including it before fsdev/meson.build. This fixes:

   ../docs/meson.build:54:2: ERROR: Unknown variable "have_virtfs_proxy_helper".

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
  meson.build       | 2 ++
  fsdev/meson.build | 1 -
  2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 3d889857a09..8f5a8b997d3 100644
--- a/meson.build
+++ b/meson.build
@@ -1032,6 +1032,8 @@
      libattr.found() and
+have_virtfs_proxy_helper = have_virtfs and have_tools
  if get_option('virtfs').enabled()
    if not have_virtfs
      if targetos != 'linux'
diff --git a/fsdev/meson.build b/fsdev/meson.build
index 65455a179e5..adf57cc43ed 100644
--- a/fsdev/meson.build
+++ b/fsdev/meson.build
@@ -8,7 +8,6 @@
  ), if_false: files('qemu-fsdev-dummy.c'))
  softmmu_ss.add_all(when: 'CONFIG_LINUX', if_true: fsdev_ss)
-have_virtfs_proxy_helper = have_tools and libattr.found() and libcap_ng.found() and have_virtfs
  if have_virtfs_proxy_helper
               files('virtfs-proxy-helper.c', '9p-marshal.c', 

Queued, thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]