[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] configure: Do not build TCG or link with capstone if not

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 0/3] configure: Do not build TCG or link with capstone if not necessary
Date: Wed, 20 Jan 2021 18:02:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 1/20/21 5:46 PM, Paolo Bonzini wrote:
> On 20/01/21 16:19, Philippe Mathieu-Daudé wrote:
>> We do not need TCG and capstone all the times. In some
>> configuration we can leave them out.
>> Last patch emit a warning when a user explicitly select an
>> accelerator that the build with not use.
>> Philippe Mathieu-Daudé (3):
>>    configure: Do not build TCG if not necessary
>>    configure: Do not build/check for capstone when emulation is disabled
>>    configure: Emit warning when accelerator requested but not needed
>>   configure | 37 ++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 36 insertions(+), 1 deletion(-)
> Nice, but I have some remarks on how the patches are done. :)
> For patch 1, which files are not compiled with the patch that were
> compiled without?


I'll mention and address Thomas and your's other comments.



> For patch 2, I think it's enough to add "build_by_default: false" to
> libcapstone (and while you're at it, to libslirp and libfdt).
> Finally, I would prefer patch 3 to be done in Meson, right before the
> summary() call.  You can use config_all to check, like
> if get_option('kvm').enabled() and not config_all.has_key('CONFIG_KVM')
> etc.  This will also warn for e.g. --enable-kvm
> --target-list=sh4-softmmu, which could be considered an improvement over
> your patch.
> Paolo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]