[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] accel/tcg: Restrict tb_gen_code() from other accelerator
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 3/6] accel/tcg: Restrict tb_gen_code() from other accelerators |
|
Date: |
Wed, 20 Jan 2021 20:06:33 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 1/17/21 11:12 PM, Claudio Fontana wrote:
> On 1/17/21 5:48 PM, Philippe Mathieu-Daudé wrote:
>> tb_gen_code() is only called within TCG accelerator,
>> declare it locally.
>
> Is this used only in accel/tcg/cpu-exec.c ? Should it be a static function
> there?
Possibly, but there's a *lot* of code that would have to be moved. For now,
queuing a slightly modified version of the patch.
>> --- a/accel/tcg/user-exec.c
>> +++ b/accel/tcg/user-exec.c
>> @@ -28,6 +28,7 @@
>> #include "qemu/atomic128.h"
>> #include "trace/trace-root.h"
>> #include "trace/mem.h"
>> +#include "internal.h"
Not needed by this patch.
r~
- [PATCH 0/6] accel: Restrict TCG-specific code, Philippe Mathieu-Daudé, 2021/01/17
- [PATCH 1/6] accel/tcg: Make cpu_gen_init() static, Philippe Mathieu-Daudé, 2021/01/17
- [PATCH 2/6] accel/tcg: Restrict tb_flush_jmp_cache() from other accelerators, Philippe Mathieu-Daudé, 2021/01/17
- [PATCH 3/6] accel/tcg: Restrict tb_gen_code() from other accelerators, Philippe Mathieu-Daudé, 2021/01/17
- [PATCH 4/6] accel/tcg: Declare missing cpu_loop_exit*() stubs, Philippe Mathieu-Daudé, 2021/01/17
- Re: [PATCH 4/6] accel/tcg: Declare missing cpu_loop_exit*() stubs, Richard Henderson, 2021/01/21
- [RFC PATCH 5/6] accel/tcg: Restrict cpu_io_recompile() from other accelerators, Philippe Mathieu-Daudé, 2021/01/17
- [RFC PATCH 6/6] softmmu: Restrict watchpoint handlers to TCG accelerator, Philippe Mathieu-Daudé, 2021/01/17