[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 6/6] softmmu: Restrict watchpoint handlers to TCG acceler
Re: [RFC PATCH 6/6] softmmu: Restrict watchpoint handlers to TCG accelerator
Wed, 20 Jan 2021 20:56:05 -1000
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0
On 1/17/21 6:48 AM, Philippe Mathieu-Daudé wrote:
> Watchpoint funtions use cpu_restore_state() which is only
> available when TCG accelerator is built. Restrict them
> to TCG.
> Signed-off-by: Philippe Mathieu-Daudé <firstname.lastname@example.org>
> RFC because we could keep that code by adding an empty
> stub for cpu_restore_state(), but it is unclear as
> the function is named generically.
> include/hw/core/cpu.h | 4 ++--
> softmmu/physmem.c | 4 ++++
> 2 files changed, 6 insertions(+), 2 deletions(-)
And all of the targets that use this are already conditionalized for this? As
opposed to leaving the declarations and adding stubs?
[RFC PATCH 5/6] accel/tcg: Restrict cpu_io_recompile() from other accelerators, Philippe Mathieu-Daudé, 2021/01/17
[RFC PATCH 6/6] softmmu: Restrict watchpoint handlers to TCG accelerator, Philippe Mathieu-Daudé, 2021/01/17
Re: [PATCH 0/6] accel: Restrict TCG-specific code, Claudio Fontana, 2021/01/18