[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 10/13] iotests: define group in each iotest

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PULL 10/13] iotests: define group in each iotest
Date: Thu, 21 Jan 2021 12:19:26 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

21.01.2021 05:36, Eric Blake wrote:
From: Vladimir Sementsov-Ogievskiy<vsementsov@virtuozzo.com>

We are going to drop group file. Define group in tests as a preparatory

The patch is generated by

     cd tests/qemu-iotests

     grep '^[0-9]\{3\} ' group | while read line; do
         file=$(awk '{print $1}' <<< "$line");
         groups=$(sed -e 's/^... //' <<< "$line");
         awk "NR==2{print \"# group: $groups\"}1" $file > tmp;
         cat tmp > $file;

Signed-off-by: Vladimir Sementsov-Ogievskiy<vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake<eblake@redhat.com>
Signed-off-by: Eric Blake<eblake@redhat.com>

Hmm. I think this patch should go together with the main series about 
refactoring iotests/check, not with preparation fixes. Otherwise we'll diverge 
if more tests will come in a mean time (or any change in group file). And just 
for good history, better keep this patch close to dropping of group file.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]