[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/8] meson: Display cryto-related information altogether
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 7/8] meson: Display cryto-related information altogether |
Date: |
Thu, 21 Jan 2021 10:13:08 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Thu, Jan 21, 2021 at 10:11:32AM +0000, Daniel P. Berrangé wrote:
> On Thu, Jan 21, 2021 at 10:56:15AM +0100, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > Cc: Daniel P. Berrange <berrange@redhat.com>
> > ---
> > meson.build | 34 +++++++++++++++++++---------------
> > 1 file changed, 19 insertions(+), 15 deletions(-)
> >
> > diff --git a/meson.build b/meson.build
> > index e372b69f163..9274775a81a 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -2453,19 +2453,8 @@
> > endif
> > summary(summary_info, bool_yn: true, section: 'Block layer support')
> >
> > +# Crypto
>
> Rather than a comment why not introduce grouping in the output
> so it is visible when reading the summary.
>
> This can be done in meson by calling summary() multiple times
> giving "section: 'Crypto'" arg.
Sigh, I'm not very good at reading this morning. I see this
is in fact done in this patch, I just couldn't see it in the
diff :-(
...
> > +summary(summary_info, bool_yn: true, section: 'Crypto')
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 0/8] meson: Clarify summary, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 1/8] meson: Summarize information related to directories first, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 2/8] meson: Display host binaries information altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 3/8] meson: Summarize overall features altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 4/8] meson: Summarize compilation-related information altogether, Philippe Mathieu-Daudé, 2021/01/21
- [RFC PATCH v2 6/8] meson: Display block layer information altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 5/8] meson: Display accelerators and selected targets altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 7/8] meson: Display cryto-related information altogether, Philippe Mathieu-Daudé, 2021/01/21
- [PATCH v2 8/8] meson: Display library dependencies altogether, Philippe Mathieu-Daudé, 2021/01/21
- Re: [PATCH v2 0/8] meson: Clarify summary, Paolo Bonzini, 2021/01/21