[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] hw/usb/dev-uas: Report command additional adb length

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 3/3] hw/usb/dev-uas: Report command additional adb length as unsupported
Date: Thu, 21 Jan 2021 14:17:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 1/21/21 12:14 PM, Gerd Hoffmann wrote:
> On Wed, Jan 20, 2021 at 04:35:22PM +0100, Philippe Mathieu-Daudé wrote:
>> We are not ready to handle additional CDB data.
>> If a guest sends a packet with such additional data,
>> report the command parameter as not supported.
>> Specify a size (of 1 byte) for the add_cdb member we
>> are not using, to fix the following warning:
>>   usb/dev-uas.c:157:31: error: field 'status' with variable sized type 
>> 'uas_iu' not at the end of a struct or class is a GNU extension 
>> [-Werror,-Wgnu-variable-sized-type-not-at-end]
>>       uas_iu                    status;
>>                                 ^
>> Reported-by: Ed Maste <emaste@FreeBSD.org>
>> Reported-by: Daniele Buono <dbuono@linux.vnet.ibm.com>
>> Reported-by: Han Han <hhan@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> v2: include Eric feedbacks
> Queued 2+3, fixup #2 conflicts due to dropping #1.

Thank you!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]