[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 07/11] iotests: add findtests.py

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v7 07/11] iotests: add findtests.py
Date: Thu, 21 Jan 2021 19:57:51 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

21.01.2021 19:21, Eric Blake wrote:
On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote:
Add python script with new logic of searching for tests:

The file findtests.py is self-executable and may be used for debugging

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

diff --git a/tests/qemu-iotests/findtests.py b/tests/qemu-iotests/findtests.py
new file mode 100644
index 0000000000..065ec13125
--- /dev/null
+++ b/tests/qemu-iotests/findtests.py
@@ -0,0 +1,159 @@
+# TestFinder class, define set of tests to run.

Per the commit message, the file is self-executable; doesn't that mean
it should have 755 permissions instead of 644, and have a #! python line?

+        return sequence

I guess it would also need a __main__ blurb at the end?  Or maybe I'm
misunderstanding the intent of the commit message line.

These things are dropped recently and I forget to updated commit-msg.

So, what should be done is just drop this sentence from commit message.

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]