[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang

From: Wainer dos Santos Moschetta
Subject: Re: [RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang
Date: Thu, 21 Jan 2021 15:05:43 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0


On 1/21/21 7:08 AM, Thomas Huth wrote:
On 10/01/2021 17.27, Philippe Mathieu-Daudé wrote:
Split the current GCC build-tci job in 2, and use Clang
compiler in the new job.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
RFC in case someone have better idea to optimize can respin this patch.

  .gitlab-ci.yml | 22 ++++++++++++++++++++--
  1 file changed, 20 insertions(+), 2 deletions(-)

I'm not quite sure whether we should go down this road ... if we wanted to have full test coverage for clang, we'd need to duplicate *all* jobs to run them once with gcc and once with clang. And that would be just overkill.

I agree with Thomas.

I think we already catch most clang-related problems with the clang jobs that we already have in our CI, so problems like the ones that you've tried to address here should be very, very rare. So I'd rather vote for not splitting the job here.

We got only one clang job on GitLab CI...

    <<: *native_build_job_definition
      IMAGE: fedora
      CONFIGURE_ARGS: --cc=clang --cxx=clang++
      TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
        ppc-softmmu s390x-softmmu arm-linux-user
      MAKE_CHECK_ARGS: check

... and others on Travis:

  "Clang (user)"

  "Clang (main-softmmu)"

  "Clang (other-softmmu)"

  "[s390x] Clang (disable-tcg)"

So I've some questions:

 * Can we move those first three Travis jobs to Gitlab CI? (I can work on that)

 * Do you think they cover the most common problems with clang?

- Wainer


reply via email to

[Prev in Thread] Current Thread [Next in Thread]