[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 04/16] block/io: refactor bdrv_pad_request(): move bdrv_pa
From: |
Eric Blake |
Subject: |
Re: [PATCH v4 04/16] block/io: refactor bdrv_pad_request(): move bdrv_pad_request() up |
Date: |
Thu, 21 Jan 2021 16:50:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
> Prepare to the following patch when bdrv_pad_request() will be able to
s/Prepare to/Prepare for/
> fail. Update the comments.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/io.c | 25 +++++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
> - if (bdrv_pad_request(bs, &qiov, &qiov_offset, &offset, &bytes, &pad)) {
> + if (padded) {
> + /*
> + * Request was unaligned to request_alignment and therefore padded.
> + * We are going to do read-modify-write. User is not prepared to
> widened
> + * request intersections with other requests, so we serialize the
> + * request.
We are going to do read-modify-write, and must serialize the request to
prevent interactions of the widened region with other transactions.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v4 04/16] block/io: refactor bdrv_pad_request(): move bdrv_pad_request() up,
Eric Blake <=