[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is avai

From: Thomas Huth
Subject: Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available
Date: Fri, 22 Jan 2021 10:43:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote:
Some new users get confused with 'TCG' and 'TCI', and enable TCI
support expecting to enable TCG.

Emit a warning when native TCG backend is available on the
host architecture, mentioning this is a suboptimal configuration.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
  meson.build | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/meson.build b/meson.build
index 0a645e54662..7aa52d306c6 100644
--- a/meson.build
+++ b/meson.build
@@ -234,6 +234,9 @@
        error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu))
+  if 'CONFIG_TCG_INTERPRETER' in config_host and cpu in supported_cpus
+    warning('Experimental TCI requested while native TCG is available on @0@, 
suboptimal performance expected'.format(cpu))
+  endif
    accelerators += 'CONFIG_TCG'
    config_host += { 'CONFIG_TCG': 'y' }

Reviewed-by: Thomas Huth <thuth@redhat.com>

... maybe you could also add some wording to the help text of the configure script? Or maybe we could simply rename the "--enable-tcg-interpreter" option into "--enable-tci" to avoid confusion with the normal TCG ?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]