Re: [PATCH v4 15/16] block/io: support int64_t bytes in read/write wrappers

[Eric Blake]

On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
> We are generally moving to int64_t for both offset and bytes parameters
> on all io paths.
> 
> Main motivation is realization of 64-bit write_zeroes operation for
> fast zeroing large disk chunks, up to the whole disk.
> 
> We chose signed type, to be consistent with off_t (which is signed) and
> with possibility for signed return type (where negative value means
> error).
> 
> Now, when bdrv_co_preadv_part() and bdrv_co_pwritev_part() updated,

s/when/since/, s/updated/have been updated/

> update all their wrappers.
> 
> For all of them type of 'bytes' is widening, so callers are safe. We
> have update request_fn in blkverify.c simultaneusly. Still it's just a

simultaneously

> pointer to on of bdrv_co_pwritev() or bdrv_co_preadv(), and type is

one

> widening for callers of the request_fn anyway.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  include/block/block.h     | 11 ++++++-----
>  include/block/block_int.h |  4 ++--
>  block/blkverify.c         |  2 +-
>  block/io.c                | 15 ++++++++-------
>  block/trace-events        |  2 +-
>  5 files changed, 18 insertions(+), 16 deletions(-)
> 
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org