[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] 9pfs/proxy: Check return value of proxy_marshal()
From: |
Greg Kurz |
Subject: |
[PULL 1/5] 9pfs/proxy: Check return value of proxy_marshal() |
Date: |
Mon, 25 Jan 2021 12:44:39 +0100 |
This should always successfully write exactly two 32-bit integers.
Make it clear with an assert(), like v9fs_receive_status() and
v9fs_receive_response() already do when unmarshalling the same
header.
Fixes: Coverity CID 1438968
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Message-Id: <161035859647.1221144.4691749806675653934.stgit@bahia.lan>
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/9pfs/9p-proxy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c
index 6f598a0f111c..4aa4e0a3baa0 100644
--- a/hw/9pfs/9p-proxy.c
+++ b/hw/9pfs/9p-proxy.c
@@ -537,7 +537,8 @@ static int v9fs_request(V9fsProxy *proxy, int type, void
*response, ...)
}
/* marshal the header details */
- proxy_marshal(iovec, 0, "dd", header.type, header.size);
+ retval = proxy_marshal(iovec, 0, "dd", header.type, header.size);
+ assert(retval == 4 * 2);
header.size += PROXY_HDR_SZ;
retval = qemu_write_full(proxy->sockfd, iovec->iov_base, header.size);
--
2.26.2
- [PULL 0/5] 9p next patches, Greg Kurz, 2021/01/25
- [PULL 1/5] 9pfs/proxy: Check return value of proxy_marshal(),
Greg Kurz <=
- [PULL 3/5] 9pfs: Convert V9fsFidState::fid_list to QSIMPLEQ, Greg Kurz, 2021/01/25
- [PULL 2/5] 9pfs: Convert V9fsFidState::clunked to bool, Greg Kurz, 2021/01/25
- [PULL 4/5] 9pfs: Improve unreclaim loop, Greg Kurz, 2021/01/25
- [PULL 5/5] 9pfs: Convert reclaim list to QSLIST, Greg Kurz, 2021/01/25
- Re: [PULL 0/5] 9p next patches, Peter Maydell, 2021/01/25