[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/25] remove -writeconfig

From: Daniel P . Berrangé
Subject: Re: [PATCH 11/25] remove -writeconfig
Date: Mon, 25 Jan 2021 14:12:00 +0000
User-agent: Mutt/1.14.6 (2020-07-11)

On Mon, Jan 25, 2021 at 03:01:01PM +0100, Paolo Bonzini wrote:
> On 25/01/21 13:53, Markus Armbruster wrote:
> > I love the "and how give me a config file for all that" idea, but I
> > agree our -writeconfig is flawed.  I hope we can bring it back in more
> > useful shape.
> > 
> > No deprecation grace period?
> > 
> That's a decision that we have to take overall once the whole series is
> reviewed, I think.  I have no problem having a grace period:

I'm normally in strongly pushing for honouring our deprecation policy,
but in almost all past cases we're changing/removing something that is
genuinely used by people in the real world.

I think it is possible to argue that -writeconfig is a special case
becuase its functionality is so limited in scope that its real world
use cases are fairly niche, and is majorly buggy in what it writes
in some cases. IOW we could argue it is too broken + useless to justify
going through the deprecation process.

So overall I'm ambivalent on whether we use deprecation for -writeconfig
or not.

> - the patches aren't 101% ready
> - the real conflict magnets have been merged already
> - I have a large KVM backlog so I don't mind leaving this aside for a few
> months

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

reply via email to

[Prev in Thread] Current Thread [Next in Thread]