[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] error: Fix "Converting to ERRP_GUARD()" doc on "valid at ret
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] error: Fix "Converting to ERRP_GUARD()" doc on "valid at return" |
Date: |
Mon, 25 Jan 2021 16:07:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/25/21 2:26 PM, Markus Armbruster wrote:
> Setting errp = NULL is wrong: the automatic error propagation still
> propagates the dangling pointer _auto_errp_prop.local_err. We need to
> set *errp = NULL to clear the dangling pointer.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qapi/error.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>