qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable


From: Stefan Hajnoczi
Subject: Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable
Date: Mon, 25 Jan 2021 16:19:00 +0000

On Mon, Jan 25, 2021 at 03:06:30PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
> 
> On 1/25/21 12:35 PM, Stefan Hajnoczi wrote:
> > Zoltan reminded me that the 'log' backend prints tids/timestamps and this 
> > can
> > be unwanted in some cases. It's easier to look at trace output without them 
> > and
> > in some cases parsing is also more convenient with them.
> > 
> > Extend -msg timestamp=on|off to control the 'log' backend's tid/timestamp 
> > output.
> > 
> > Stefan Hajnoczi (2):
> >   error: rename error_with_timestamp to message_with_timestamp
> >   trace: make the 'log' backend timestamp configurable
> > 
> >  docs/devel/tracing.txt           |  3 +++
> >  include/qemu/error-report.h      |  2 +-
> >  softmmu/vl.c                     |  2 +-
> >  util/qemu-error.c                |  4 ++--
> >  scripts/tracetool/backend/log.py | 19 +++++++++++++------
> >  5 files changed, 20 insertions(+), 10 deletions(-)
> 
> I applied your series, rebuilt, but nothing changed.
> 
> Apparently there is some buildsys rule missing, the
> trace files weren't regenerated.

I sent a separate patch that adds tracetool dependencies to meson.build:
"[PATCH] trace: add meson custom_target() depend_files for tracetool"

That will fix the issue.

Stefan

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]