[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility function
From: |
Taylor Simpson |
Subject: |
RE: [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions |
Date: |
Mon, 25 Jan 2021 21:43:19 +0000 |
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Monday, January 25, 2021 10:30 AM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: ale@rev.ng; alex.bennee@linaro.org; richard.henderson@linaro.org;
> laurent@vivier.eu; Brian Cain <bcain@quicinc.com>
> Subject: Re: [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility
> functions
>
> >>> diff --git a/target/hexagon/arch.c b/target/hexagon/arch.c
> >>> new file mode 100644
> >>> index 0000000..c59cad5
> >>> --- /dev/null
> >>> +++ b/target/hexagon/arch.c
> >> ...
> >>
> >>> +#define RAISE_FP_EXCEPTION \
> >>> + do {} while (0) /* Not modelled in qemu user mode */
> >>
> >> I don't understand why... Can you explain please?
> >
> > Our Linux kernel only sets the relevant bits in USR (user status register).
> The exception isn't raised to user mode.
>
> Hmm while you introduce the linux-user implementation of your port,
> this file is not restricted to user mode. Thinking about avoiding
> head aches to someone wanting to add system mode emulation (or a
> BSD port??), maybe your helpers should consider that.
> Maybe some cheap #ifdef'ry CONFIG_USER_ONLY with a comment
> explaining
> why there is nothing to do in user mode, and g_assert_not_reached()
> else. Not sure, just wondering...
Sorry, I misunderstood the question. You are correct. It's a placeholder for
future work to support system mode. I'll add the #ifdef and some comments to
explain.
Thanks,
Taylor
- [PATCH v7 35/35] Add Dockerfile for hexagon, (continued)
[PATCH v7 19/35] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics, Taylor Simpson, 2021/01/19
[PATCH v7 22/35] Hexagon (target/hexagon) generater phase 4 - decode tree, Taylor Simpson, 2021/01/19
[PATCH v7 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions, Taylor Simpson, 2021/01/19
[PATCH v7 18/35] Hexagon (target/hexagon/imported) arch import, Taylor Simpson, 2021/01/19
[PATCH v7 20/35] Hexagon (target/hexagon) generator phase 2 - generate header files, Taylor Simpson, 2021/01/19
[PATCH v7 26/35] Hexagon (target/hexagon) TCG generation, Taylor Simpson, 2021/01/19
[PATCH v7 27/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions, Taylor Simpson, 2021/01/19
[PATCH v7 23/35] Hexagon (target/hexagon) opcode data structures, Taylor Simpson, 2021/01/19
[PATCH v7 29/35] Hexagon (target/hexagon) translation, Taylor Simpson, 2021/01/19
[PATCH v7 28/35] Hexagon (target/hexagon) TCG for floating point instructions, Taylor Simpson, 2021/01/19