[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: accept either shared or static libraries if --disable

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] meson: accept either shared or static libraries if --disable-static
Date: Tue, 26 Jan 2021 14:13:19 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 1/26/21 11:27 AM, Paolo Bonzini wrote:
> Meson's "static" argument to cc.find_library is a tri-state.  By default
> Meson *prefers* a shared library, which basically means using -l to
> look for it; instead, "static: false" *requires* a shared library.  Of
> course, "static: true" requires a static library, which is all good
> for --enable-static builds.
> For --disable-static, "static: false" is rarely desirable; it does not
> match what the configure script used to do and the test is more complex
> (and harder to debug if it fails, which was reported by Peter Lieven
> for librbd).
> Reported-by: Peter Lieven <pl@kamp.de>
> Tested-by: Peter Lieven <pl@kamp.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  docs/devel/build-system.rst |  2 +-
>  meson.build                 | 79 +++++++++++++++++++------------------
>  2 files changed, 42 insertions(+), 39 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]