[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/12] buildsys: Do not build various objects if not neces

From: Markus Armbruster
Subject: Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary
Date: Tue, 26 Jan 2021 17:09:40 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 1/26/21 3:57 PM, Alex Bennée wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>> In this series we deselect a bunch of features when they
>>> not required, so less objects are built.
>>> While this reduce pressure on CI and slow systems, this is
>>> particularly helpful for developers regularly testing multiple
>>> build configurations.
>>> All CI tests pass:
>>> https://gitlab.com/philmd/qemu/-/pipelines/245654160
>>> Supersedes: <20210120151916.1167448-1-philmd@redhat.com>
>> Series looks good to me but I guess you need some sub-system feedback.
> Yeah, I will wait for Markus feedback on qapi/ before respining (with
> target/ fix), ...

Maybe I'm naive today, but to me this looks like a case of "if it still
builds, it's fine".

Anything in particular you want my feedback for?

>> I've sent a few more patches that might be worth rolling in to better
>> handle check-tcg/softfloat.
> ... including your patches if they aren't merged before.
> Thanks for having a look,
> Phil.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]