[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is a

From: Stefan Weil
Subject: Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available
Date: Wed, 27 Jan 2021 07:53:14 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

Am 26.01.21 um 23:39 schrieb Richard Henderson:

On 1/26/21 9:44 AM, Stefan Weil wrote:
I was not talking about the TODO assertions. When I wrote TCI, I only enabled
and included code which was triggered by my testing - that's why I said the
productive code lines have 100 % test coverage. TODO assertions are not
productive code, but debug code which were made to detect new test cases. They
were successful, too, because they were triggered by some tests in `make
The TODO assertions are all bugs.

Any *real* dead code detection should have been done in
tcg/tci/tcg-target.c.inc.  What's interpreted in tcg/tci.c should be exactly
what is produced on the other side, and you are producing more than you are

Unless the TCG opcodes in tcg/tci/tcg-target.c.inc are used in real-live scenarios, they are dead code, too.

Writing a test case which produces them directly (not for some real architecture) is not a real-live scenario.

And the remaining TODO assertions are a good indicator that the current tests are incomplete for native TCG because they obviously don't cover all TCG opcodes.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]