[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iotests/297: pylint: ignore too many statements

From: Kevin Wolf
Subject: Re: [PATCH] iotests/297: pylint: ignore too many statements
Date: Fri, 29 Jan 2021 10:50:18 +0100

Am 28.01.2021 um 21:08 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 28.01.2021 23:04, Vladimir Sementsov-Ogievskiy wrote:
> > Ignore two complains, which now lead to 297 failure on testenv.py and
> > testrunner.py.
> > 
> > Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
> > Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> Forget to note:
> I don't add exclusions to pylintrc intentionally, as I think these
> warnings are reasonable, and it's good that vim ALE show them.. Still,
> adding them to pylintrc works too if you prefer.

I would have disabled the warning completely because I don't think
length in lines is a good measure for code quality. But if we think that
these warnings are in fact reasonable, then we should fix them and not
just disable them partially.

It's the same reason why we have -Werror enabled. If you leave warnings
around without any intention to fix them, the useful warnings will drown
in the masses of intentionally ignored ones.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]