[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] accel/tcg: Add URL of clang bug to comment about our workaro

From: Alex Bennée
Subject: Re: [PATCH] accel/tcg: Add URL of clang bug to comment about our workaround
Date: Fri, 29 Jan 2021 15:19:46 +0000
User-agent: mu4e 1.5.7; emacs 28.0.50

Peter Maydell <peter.maydell@linaro.org> writes:

> In cpu_exec() we have a longstanding workaround for compilers which
> do not correctly implement the part of the sigsetjmp()/siglongjmp()
> spec which requires that local variables which are not changed
> between the setjmp and the longjmp retain their value.
> I recently ran across the upstream clang bug report for this; add a
> link to it to the comment describing the workaround, and generally
> expand the comment, so that we have a reasonable chance in future of
> understanding why it's there and determining when we can remove it,
> assuming clang eventually fixes the bug.
> Remove the /* buggy compiler */ comments on the #else and #endif:
> they don't add anything to understanding and are somewhat misleading
> since they're sandwiching the code path for *non*-buggy compilers.
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]