[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/8] tests/docker: alias docker-help target for consistenc

From: Thomas Huth
Subject: Re: [PATCH v2 5/8] tests/docker: alias docker-help target for consistency
Date: Fri, 29 Jan 2021 16:49:31 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

On 22/01/2021 19.18, Alex Bennée wrote:
We have a bunch of -help targets so this will save some cognitive
dissonance. Keep the original for those with muscle memory.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
  tests/docker/Makefile.include | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index bdc53ddfcf..a5c1e4a615 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -1,6 +1,6 @@
  # Makefile for Docker tests
-.PHONY: docker docker-test docker-clean docker-image docker-qemu-src
+.PHONY: docker docker-help docker-test docker-clean docker-image 
  SPACE := $(NULL) #
@@ -218,6 +218,8 @@ endif
        @echo '                         Specify which container engine to run.'
        @echo '    REGISTRY=url         Cache builds from registry 
+docker-help: docker
  # This rule if for directly running against an arbitrary docker target.
  # It is called by the expanded docker targets (e.g. make
  # docker-test-foo@bar) which will do additional verification.

Do you also want to rename it in the main Makefile:

 $(call print-help,docker,Help about targets running tests inside containers)


Reviewed-by: Thomas Huth <thuth@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]