[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 2/4] hw/ide/Kconfig: IDE_PIIX requires IDE_ISA

From: Paolo Bonzini
Subject: Re: [RFC PATCH 2/4] hw/ide/Kconfig: IDE_PIIX requires IDE_ISA
Date: Fri, 29 Jan 2021 21:00:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 29/01/21 20:44, Philippe Mathieu-Daudé wrote:
hw/ide/piix.c has a strong dependency on hw/isa/isa-bus.c:

   /usr/bin/ld: libcommon.fa.p/hw_ide_piix.c.o: in function 
   /usr/bin/ld: hw/ide/piix.c:141: undefined reference to `isa_get_irq'

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
  hw/ide/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig
index 41cdd9cbe03..0f5d316558b 100644
--- a/hw/ide/Kconfig
+++ b/hw/ide/Kconfig
@@ -17,6 +17,7 @@ config IDE_ISA
config IDE_PIIX
+    select IDE_ISA
      select IDE_PCI
      select IDE_QDEV

This is also incorrect, it should be "depends on ISA_BUS".


reply via email to

[Prev in Thread] Current Thread [Next in Thread]