[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass
From: |
Alex Bennée |
Subject: |
Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass |
Date: |
Mon, 01 Feb 2021 09:15:49 +0000 |
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> On 1/30/21 12:53 AM, Claudio Fontana wrote:
>> To summarize:
>>
>> 1) accel->cpu_realizefn extends the current cpu target-specific realize
>> functions with accelerator-specific code,
>> which currently does not make use of errp at all (thus, the temptation to
>> remove errp from the interface until it is actually needed by a target).
>
> No, arm does use errp in realizefn already.
> It's just that the void return value is hinky.
Sounds like fixing the void return would be part of a larger qdev
clean-up rather than this particular series. If I recall there have been
various phases of clean-ups and refactoring of the error code paths in
the past.
>
>
> r~
--
Alex Bennée
- Re: [PATCH v14 18/22] accel: introduce AccelCPUClass extending CPUClass,
Alex Bennée <=