[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 07/15] configure: make version_ge more tolerant of shady v
From: |
Eric Blake |
Subject: |
Re: [PATCH v1 07/15] configure: make version_ge more tolerant of shady version input |
Date: |
Tue, 2 Feb 2021 08:17:57 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/2/21 7:39 AM, Alex Bennée wrote:
> When checking GDB versions we have to tolerate all sorts of random
> distro extensions to the version string. While we already attempt to
> do some of that before we call version_ge is makes sense to try and
> regularise the first input by stripping extraneous -'s. While we at it
> convert the old-style shell quoting into a cleaner form t shut up my
> editors linter lest it confuse me by underlining the whole line.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Tested-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index e85d6baf8f..432b83fadf 100755
> --- a/configure
> +++ b/configure
> @@ -198,8 +198,8 @@ has() {
> }
>
> version_ge () {
> - local_ver1=`echo $1 | tr . ' '`
> - local_ver2=`echo $2 | tr . ' '`
> + local_ver1=$(expr "$1" : '\([0-9.]*\)' | tr . ' ')
> + local_ver2=$(echo "$2" | tr . ' ')
> while true; do
> set x $local_ver1
> local_first=${2-0}
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v1 02/15] tests/docker: Fix typo in help message, (continued)
- [PATCH v1 02/15] tests/docker: Fix typo in help message, Alex Bennée, 2021/02/02
- [PATCH v1 01/15] tests/docker: Fix _get_so_libs() for docker-binfmt-image, Alex Bennée, 2021/02/02
- [PATCH v1 04/15] tests/docker: preserve original name when copying libs, Alex Bennée, 2021/02/02
- [PATCH v1 03/15] tests/docker: make _copy_with_mkdir accept missing files, Alex Bennée, 2021/02/02
- [PATCH v1 05/15] tests/docker: alias docker-help target for consistency, Alex Bennée, 2021/02/02
- [PATCH v1 06/15] tests/docker: add a docker-exec-copy-test, Alex Bennée, 2021/02/02
- [PATCH v1 08/15] configure: bump the minimum gdb version for check-tcg to 9.1, Alex Bennée, 2021/02/02
- [PATCH v1 09/15] tests/tcg: don't silently skip the gdb tests, Alex Bennée, 2021/02/02
- [PATCH v1 07/15] configure: make version_ge more tolerant of shady version input, Alex Bennée, 2021/02/02
- Re: [PATCH v1 07/15] configure: make version_ge more tolerant of shady version input,
Eric Blake <=
- [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS), Alex Bennée, 2021/02/02
- [PATCH v1 12/15] scripts/mtest2make.py: export all-%s-targets variable and use it, Alex Bennée, 2021/02/02
- [PATCH v1 10/15] gdbstub: Fix handle_query_xfer_auxv, Alex Bennée, 2021/02/02
- [PATCH v1 13/15] tests/Makefile.include: don't use TARGET_DIRS for check-tcg, Alex Bennée, 2021/02/02
- [PATCH v1 15/15] docs/system: document an example booting the versatilepb machine, Alex Bennée, 2021/02/02
- [PATCH v1 14/15] docs/system: document an example vexpress-a15 invocation, Alex Bennée, 2021/02/02