[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 05/16] qapi: centralize is_[user|system|builtin]_module me

From: John Snow
Subject: Re: [PATCH v4 05/16] qapi: centralize is_[user|system|builtin]_module methods
Date: Tue, 2 Feb 2021 11:05:43 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 2/2/21 4:16 AM, Markus Armbruster wrote:
Putting these functions into a class feels awkward.  But it does the

Yes, I recognize that. I really wanted:

1) To centralize them somewhere, so there was somewhere obvious to look for these definitions, but

2) We aren't really using the classiness in a meaningful way, so

3) The names are a little awkward as you mentioned.

We can rewrite them as functions if you want, maybe with a comment for the class that says "Hey, go look at these functions!" but that didn't feel less messy to me. I couldn't really find anything that I actually genuinely liked. I went with a subjective least-worst.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]