[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 01/12] block: push error reporting into bdrv_all_*_snapsh
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v10 01/12] block: push error reporting into bdrv_all_*_snapshot functions |
|
Date: |
Tue, 2 Feb 2021 11:25:01 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/2/21 9:41 AM, Daniel P. Berrangé wrote:
> The bdrv_all_*_snapshot functions return a BlockDriverState pointer
> for the invalid backend, which the callers then use to report an
> error message. In some cases multiple callers are reporting the
> same error message, but with slightly different text. In the future
> there will be more error scenarios for some of these methods, which
> will benefit from fine grained error message reporting. So it is
> helpful to push error reporting down a level.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> [PMD: Initialize variables]
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> block/monitor/block-hmp-cmds.c | 7 ++--
> block/snapshot.c | 77 +++++++++++++++++-----------------
> include/block/snapshot.h | 14 +++----
> migration/savevm.c | 39 +++++------------
> monitor/hmp-cmds.c | 7 +---
> replay/replay-debugging.c | 4 +-
> tests/qemu-iotests/267.out | 10 ++---
> 7 files changed, 68 insertions(+), 90 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v10 00/12] migration: bring improved savevm/loadvm/delvm to QMP, Daniel P . Berrangé, 2021/02/02
- [PATCH v10 01/12] block: push error reporting into bdrv_all_*_snapshot functions, Daniel P . Berrangé, 2021/02/02
- Re: [PATCH v10 01/12] block: push error reporting into bdrv_all_*_snapshot functions,
Eric Blake <=
- [PATCH v10 02/12] migration: Make save_snapshot() return bool, not 0/-1, Daniel P . Berrangé, 2021/02/02
- [PATCH v10 04/12] block: add ability to specify list of blockdevs during snapshot, Daniel P . Berrangé, 2021/02/02
- [PATCH v10 05/12] block: allow specifying name of block device for vmstate storage, Daniel P . Berrangé, 2021/02/02
- [PATCH v10 03/12] migration: stop returning errno from load_snapshot(), Daniel P . Berrangé, 2021/02/02
- [PATCH v10 10/12] iotests: add support for capturing and matching QMP events, Daniel P . Berrangé, 2021/02/02
- [PATCH v10 11/12] iotests: fix loading of common.config from tests/ subdir, Daniel P . Berrangé, 2021/02/02
- [PATCH v10 06/12] block: rename and alter bdrv_all_find_snapshot semantics, Daniel P . Berrangé, 2021/02/02
- [PATCH v10 08/12] migration: wire up support for snapshot device selection, Daniel P . Berrangé, 2021/02/02