[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 09/14] qapi/introspect.py: improve _tree_to_qlit error message
From: |
John Snow |
Subject: |
[PATCH v4 09/14] qapi/introspect.py: improve _tree_to_qlit error message |
Date: |
Tue, 2 Feb 2021 12:46:46 -0500 |
Trivial; make the error message just a pinch more explicit in case we
trip this by accident in the future.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/introspect.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index 2b90a52f016..c72beeeed27 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -124,7 +124,9 @@ def indent(level):
elif isinstance(obj, bool):
ret += 'QLIT_QBOOL(%s)' % ('true' if obj else 'false')
else:
- assert False # not implemented
+ raise NotImplementedError(
+ f"type '{type(obj).__name__}' not implemented"
+ )
if level > 0:
ret += ','
return ret
--
2.29.2
- [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, (continued)
- [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, John Snow, 2021/02/02
- Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, Markus Armbruster, 2021/02/03
- Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, Eduardo Habkost, 2021/02/03
- Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, Markus Armbruster, 2021/02/04
- Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, John Snow, 2021/02/04
- Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, Eduardo Habkost, 2021/02/04
- Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, Markus Armbruster, 2021/02/05
- Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, John Snow, 2021/02/03
- Re: [PATCH v4 08/14] qapi/introspect.py: create a typed 'Annotated' data strutcure, Markus Armbruster, 2021/02/05
[PATCH v4 10/14] qapi/introspect.py: improve readability of _tree_to_qlit, John Snow, 2021/02/02
[PATCH v4 09/14] qapi/introspect.py: improve _tree_to_qlit error message,
John Snow <=
[PATCH v4 11/14] qapi/introspect.py: add type hint annotations, John Snow, 2021/02/02
- Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations, Markus Armbruster, 2021/02/03
- Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations, John Snow, 2021/02/03
- Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations, Markus Armbruster, 2021/02/05
- Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations, John Snow, 2021/02/08
- Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations, John Snow, 2021/02/08
- Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations, Markus Armbruster, 2021/02/09
- Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations, John Snow, 2021/02/10
[PATCH v4 12/14] qapi/introspect.py: add introspect.json dummy types, John Snow, 2021/02/02
[PATCH v4 14/14] qapi/introspect.py: Update copyright and authors list, John Snow, 2021/02/02