[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/20] ui: add an optional get_flags callback to GraphicHwOps
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 11/20] ui: add an optional get_flags callback to GraphicHwOps |
Date: |
Wed, 3 Feb 2021 16:48:20 +0100 |
> +static int
> +virtio_gpu_get_flags(void *opaque)
> +{
> + VirtIOGPUBase *g = opaque;
> + int flags = GRAPHIC_FLAGS_NONE;
> +
> + if (virtio_gpu_virgl_enabled(g->conf))
> + flags |= GRAPHIC_FLAGS_GL;
> +
> + if (virtio_gpu_dmabuf_enabled(g->conf))
> + flags |= GRAPHIC_FLAGS_DMABUF;
fbe6ba76ac01 ui: add an optional get_flags callback to GraphicHwOps
ERROR: braces {} are necessary for all arms of this statement
#50: FILE: hw/display/virtio-gpu-base.c:123:
+ if (virtio_gpu_virgl_enabled(g->conf))
[...]
ERROR: braces {} are necessary for all arms of this statement
#53: FILE: hw/display/virtio-gpu-base.c:126:
+ if (virtio_gpu_dmabuf_enabled(g->conf))
[...]
total: 2 errors, 0 warnings, 68 lines checked
- [PATCH 02/20] vhost-user-gpu: handle vhost-user-gpu features in a callback, (continued)
- [PATCH 02/20] vhost-user-gpu: handle vhost-user-gpu features in a callback, marcandre . lureau, 2021/02/02
- [PATCH 03/20] vhost-user-gpu: use an extandable state enum for commands, marcandre . lureau, 2021/02/02
- [PATCH 04/20] vhost-user-gpu: handle display-info in a callback, marcandre . lureau, 2021/02/02
- [PATCH 05/20] ui: remove extra #ifdef CONFIG_OPENGL, marcandre . lureau, 2021/02/02
- [PATCH 06/20] ui: remove gl_ctx_get_current, marcandre . lureau, 2021/02/02
- [PATCH 07/20] ui: add gd_gl_area_scanout_disable, marcandre . lureau, 2021/02/02
- [PATCH 08/20] ui: annotate DCLOps callback requirements, marcandre . lureau, 2021/02/02
- [PATCH 09/20] ui: remove console_has_gl_dmabuf(), marcandre . lureau, 2021/02/02
- [PATCH 10/20] vhost-user-gpu: add a configuration flag for dmabuf usage, marcandre . lureau, 2021/02/02
- [PATCH 11/20] ui: add an optional get_flags callback to GraphicHwOps, marcandre . lureau, 2021/02/02
- Re: [PATCH 11/20] ui: add an optional get_flags callback to GraphicHwOps,
Gerd Hoffmann <=
- [PATCH 12/20] ui: add a DCLOps callback to check dmabuf support, marcandre . lureau, 2021/02/02
- [PATCH 13/20] ui: check hw requirements during DCL registration, marcandre . lureau, 2021/02/02
- [PATCH 14/20] ui: add qemu_egl_has_dmabuf helper, marcandre . lureau, 2021/02/02
- [PATCH 15/20] ui: check gtk-egl dmabuf support, marcandre . lureau, 2021/02/02
- [PATCH 16/20] ui: add egl dmabuf import to gtkglarea, marcandre . lureau, 2021/02/02
- [PATCH 17/20] virtio-gpu: avoid re-entering cmdq processing, marcandre . lureau, 2021/02/02
- [PATCH 18/20] display/ui: add a callback to indicate GL state is flushed, marcandre . lureau, 2021/02/02
- [PATCH 19/20] chardev: check if the chardev is registered for yanking, marcandre . lureau, 2021/02/02