[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/4] target/arm: Support AA32 DIT by moving PSTATE_SS from
From: |
Richard Henderson |
Subject: |
Re: [PATCH v4 2/4] target/arm: Support AA32 DIT by moving PSTATE_SS from cpsr into env->pstate |
Date: |
Wed, 3 Feb 2021 07:19:20 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/2/21 6:58 PM, Rebecca Cran wrote:
> @@ -9433,8 +9448,9 @@ static void take_aarch32_exception(CPUARMState *env,
> int new_mode,
> * For exceptions taken to AArch32 we must clear the SS bit in both
> * PSTATE and in the old-state value we save to SPSR_<mode>, so zero it
> now.
> */
> - env->uncached_cpsr &= ~PSTATE_SS;
> - env->spsr = cpsr_read(env);
> + env->pstate &= ~PSTATE_SS;
> + env->spsr = cpsr_read_for_spsr_elx(env);
> +
Again, this is the aarch32 exception path, and should not use
cpsr_read_for_spsr_elx.
r~