[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 10/15] qapi/introspect.py: improve _tree_to_qlit error message
From: |
John Snow |
Subject: |
[PATCH v5 10/15] qapi/introspect.py: improve _tree_to_qlit error message |
Date: |
Wed, 3 Feb 2021 19:32:02 -0500 |
Trivial; make the error message just a pinch more explicit in case we
trip this by accident in the future.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/introspect.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index b9427aba449..0146e4c6a0c 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -124,7 +124,9 @@ def indent(level):
elif isinstance(obj, bool):
ret += 'QLIT_QBOOL(%s)' % ('true' if obj else 'false')
else:
- assert False # not implemented
+ raise NotImplementedError(
+ f"type '{type(obj).__name__}' not implemented"
+ )
if level > 0:
ret += ','
return ret
--
2.29.2
- [PATCH v5 00/15] qapi: static typing conversion, pt2, John Snow, 2021/02/03
- [PATCH v5 01/15] qapi/introspect.py: assert schema is not None, John Snow, 2021/02/03
- [PATCH v5 02/15] qapi/introspect.py: use _make_tree for features nodes, John Snow, 2021/02/03
- [PATCH v5 03/15] qapi/introspect.py: add _gen_features helper, John Snow, 2021/02/03
- [PATCH v5 04/15] qapi/introspect.py: guard against ifcond/comment misuse, John Snow, 2021/02/03
- [PATCH v5 07/15] qapi/introspect.py: Always define all 'extra' dict keys, John Snow, 2021/02/03
- [PATCH v5 06/15] qapi/introspect.py: replace 'extra' dict with 'comment' argument, John Snow, 2021/02/03
- [PATCH v5 05/15] qapi/introspect.py: Unify return type of _make_tree(), John Snow, 2021/02/03
- [PATCH v5 10/15] qapi/introspect.py: improve _tree_to_qlit error message,
John Snow <=
- [PATCH v5 09/15] qapi/introspect.py: create a typed 'Annotated' data strutcure, John Snow, 2021/02/03
- [PATCH v5 11/15] qapi/introspect.py: improve readability of _tree_to_qlit, John Snow, 2021/02/03
- [PATCH v5 12/15] qapi/introspect.py: add type hint annotations, John Snow, 2021/02/03
[PATCH v5 13/15] qapi/introspect.py: add introspect.json dummy types, John Snow, 2021/02/03