[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 64/93] tcg/tci: Improve tcg_target_call_clobber_regs
From: |
Richard Henderson |
Subject: |
[PATCH v2 64/93] tcg/tci: Improve tcg_target_call_clobber_regs |
Date: |
Wed, 3 Feb 2021 15:44:40 -1000 |
The current setting is much too pessimistic. Indicating only
the one or two registers that are actually assigned after a
call should avoid unnecessary movement between the register
array and the stack array.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tci/tcg-target.c.inc | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
index 8d75482546..4dae09deda 100644
--- a/tcg/tci/tcg-target.c.inc
+++ b/tcg/tci/tcg-target.c.inc
@@ -623,8 +623,14 @@ static void tcg_target_init(TCGContext *s)
tcg_target_available_regs[TCG_TYPE_I32] = BIT(TCG_TARGET_NB_REGS) - 1;
/* Registers available for 64 bit operations. */
tcg_target_available_regs[TCG_TYPE_I64] = BIT(TCG_TARGET_NB_REGS) - 1;
- /* TODO: Which registers should be set here? */
- tcg_target_call_clobber_regs = BIT(TCG_TARGET_NB_REGS) - 1;
+ /*
+ * The interpreter "registers" are in the local stack frame and
+ * cannot be clobbered by the called helper functions. However,
+ * the interpreter assumes a 64-bit return value and assigns to
+ * the return value registers.
+ */
+ tcg_target_call_clobber_regs =
+ MAKE_64BIT_MASK(TCG_REG_R0, 64 / TCG_TARGET_REG_BITS);
s->reserved_regs = 0;
tcg_regset_set_reg(s->reserved_regs, TCG_REG_CALL_STACK);
--
2.25.1
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, (continued)
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Paolo Bonzini, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Stefan Weil, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Stefan Weil, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/09
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Stefan Weil, 2021/02/09
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Stefan Weil, 2021/02/09
[PATCH v2 65/93] tcg/tci: Move call-return regs to end of tcg_target_reg_alloc_order, Richard Henderson, 2021/02/03
[PATCH v2 66/93] tcg/tci: Push opcode emit into each case, Richard Henderson, 2021/02/03
[PATCH v2 64/93] tcg/tci: Improve tcg_target_call_clobber_regs,
Richard Henderson <=
[PATCH v2 67/93] tcg/tci: Split out tcg_out_op_rrs, Richard Henderson, 2021/02/03
[PATCH v2 69/93] tcg/tci: Split out tcg_out_op_p, Richard Henderson, 2021/02/03
[PATCH v2 71/93] tcg/tci: Split out tcg_out_op_rrr, Richard Henderson, 2021/02/03
[PATCH v2 74/93] tcg/tci: Split out tcg_out_op_rrrbb, Richard Henderson, 2021/02/03
[PATCH v2 72/93] tcg/tci: Split out tcg_out_op_rrrc, Richard Henderson, 2021/02/03
[PATCH v2 73/93] tcg/tci: Split out tcg_out_op_rrrrrc, Richard Henderson, 2021/02/03
[PATCH v2 68/93] tcg/tci: Split out tcg_out_op_l, Richard Henderson, 2021/02/03
[PATCH v2 78/93] tcg/tci: Split out tcg_out_op_rrrrcl, Richard Henderson, 2021/02/03
[PATCH v2 79/93] tcg/tci: Split out tcg_out_op_{rrm,rrrm,rrrrm}, Richard Henderson, 2021/02/03
[PATCH v2 70/93] tcg/tci: Split out tcg_out_op_rr, Richard Henderson, 2021/02/03