[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate strin
From: |
Beraldo Leal |
Subject: |
Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length |
Date: |
Thu, 4 Feb 2021 08:07:21 -0300 |
On Wed, Feb 03, 2021 at 12:23:42PM -0500, Cleber Rosa wrote:
> If the vmlinuz variable is set to anything that evaluates to True,
> then the respective arguments should be set. If the variable contains
> an empty string, than it will evaluate to False, and the extra
> arguments will not be set.
>
> This keeps the same logic, but improves readability a bit.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/virtiofs_submounts.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/virtiofs_submounts.py
> b/tests/acceptance/virtiofs_submounts.py
> index f1b49f03bb..f25a386a19 100644
> --- a/tests/acceptance/virtiofs_submounts.py
> +++ b/tests/acceptance/virtiofs_submounts.py
> @@ -241,7 +241,7 @@ class VirtiofsSubmountsTest(BootLinux):
>
> super(VirtiofsSubmountsTest, self).setUp(pubkey)
>
> - if len(vmlinuz) > 0:
> + if vmlinuz:
> self.vm.add_args('-kernel', vmlinuz,
> '-append', 'console=ttyS0 root=/dev/sda1')
>
> --
> 2.25.4
>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
- Re: [PATCH 13/22] tests/acceptance/virtiofs_submounts.py: add missing accel tag, (continued)
- [PATCH 06/22] tests/acceptance/virtiofs_submounts.py: use a virtio-net device instead, Cleber Rosa, 2021/02/03
- [PATCH 14/22] Acceptance Tests: introduce LinuxTest base class, Cleber Rosa, 2021/02/03
- [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Cleber Rosa, 2021/02/03
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length,
Beraldo Leal <=
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Alex Bennée, 2021/02/04
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Max Reitz, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Alex Bennée, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Max Reitz, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Alex Bennée, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Max Reitz, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Alex Bennée, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Philippe Mathieu-Daudé, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Cleber Rosa, 2021/02/15
[PATCH 18/22] Acceptance Tests: set up existing ssh keys by default, Cleber Rosa, 2021/02/03