[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 27/93] tcg/tci: Fix TCG_REG_R4 misusage
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 27/93] tcg/tci: Fix TCG_REG_R4 misusage |
Date: |
Thu, 04 Feb 2021 15:09:52 +0000 |
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> This was removed from tcg_target_reg_alloc_order and
> tcg_target_call_iarg_regs on the assumption that it
> was the stack. This was incorrectly copied from i386.
> For tci, the stack is R15.
>
> By adding R4 back to tcg_target_call_iarg_regs, adjust the other
> entries so that 6 (or 12) entries are still present in the array,
> and adjust the numbers in the interpreter.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- [PATCH v2 20/93] tcg/tci: Move stack bounds check to compile-time, (continued)
- [PATCH v2 20/93] tcg/tci: Move stack bounds check to compile-time, Richard Henderson, 2021/02/03
- [PATCH v2 19/93] tcg/tci: Merge INDEX_op_st16_{i32,i64}, Richard Henderson, 2021/02/03
- [PATCH v2 23/93] tcg/tci: Remove dead code for TCG_TARGET_HAS_div2_*, Richard Henderson, 2021/02/03
- [PATCH v2 25/93] tcg/tci: Remove TODO as unused, Richard Henderson, 2021/02/03
- [PATCH v2 21/93] tcg/tci: Merge INDEX_op_{st_i32,st32_i64}, Richard Henderson, 2021/02/03
- [PATCH v2 22/93] tcg/tci: Use g_assert_not_reached, Richard Henderson, 2021/02/03
- [PATCH v2 26/93] tcg/tci: Restrict TCG_TARGET_NB_REGS to 16, Richard Henderson, 2021/02/03
- [PATCH v2 24/93] tcg/tci: Implement 64-bit division, Richard Henderson, 2021/02/03
- [PATCH v2 27/93] tcg/tci: Fix TCG_REG_R4 misusage, Richard Henderson, 2021/02/03
- Re: [PATCH v2 27/93] tcg/tci: Fix TCG_REG_R4 misusage,
Alex Bennée <=
- [PATCH v2 35/93] tcg/tci: Remove tci_read_r32s, Richard Henderson, 2021/02/03
- [PATCH v2 28/93] tcg/tci: Use bool in tcg_out_ri*, Richard Henderson, 2021/02/03
- [PATCH v2 39/93] tcg/tci: Remove ifdefs for TCG_TARGET_HAS_ext32[us]_i64, Richard Henderson, 2021/02/03
- [PATCH v2 41/93] tcg/tci: Merge mov, not and neg operations, Richard Henderson, 2021/02/03
- [PATCH v2 30/93] tcg/tci: Merge identical cases in generation, Richard Henderson, 2021/02/03
- [PATCH v2 38/93] tcg/tci: Merge extension operations, Richard Henderson, 2021/02/03
- [PATCH v2 43/93] tcg/tci: Split out tci_args_rrs, Richard Henderson, 2021/02/03
- [PATCH v2 29/93] tcg/tci: Remove TCG_CONST, Richard Henderson, 2021/02/03