Re: [PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands

[Daniel P . Berrangé]

On Thu, Feb 04, 2021 at 03:34:33PM +0000, Dr. David Alan Gilbert wrote:
> This is (intermittently?) failing for me because of ordering issues:
> 
> --- 
> /home/dgilbert/git/migpull/tests/qemu-iotests/tests/internal-snapshots-qapi.out
> +++ internal-snapshots-qapi.out.bad
> @@ -344,8 +344,8 @@
>                                       "vmstate": "diskfmt0",
>                                       "devices": ["diskfmt0"]}}
>  {"return": {}}
> +qemu-system-x86_64: Unknown savevm section or instance 
> '0000:00:02.0/virtio-rng' 0. Make sure that your current VM setup matches 
> your saved VM setup, including any hotplugged devices
>  {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": 
> "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "load-err-stderr"}}
> -qemu-system-x86_64: Unknown savevm section or instance 
> '0000:00:02.0/virtio-rng' 0. Make sure that your current VM setup matches 
> your saved VM setup, including any hotplugged devices
>  {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": 
> "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "load-err-stderr"}}
>  {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": 
> "STOP"}
>  {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": 
> "JOB_STATUS_CHANGE", "data": {"status": "aborting", "id": "load-err-stderr"}}
> Not run: 259
> Failures: internal-snapshots-qapi
> Failed 1 of 124 iotests
> 
> I'll disable the test for now.

Ok. I'm working on a patch series to make migration code use "Error **errp"
that ought to fix this properly.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|