[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 21/33] migration: remove error reporting from qemu_fopen_bdrv() c
From: |
Daniel P . Berrangé |
Subject: |
[PATCH 21/33] migration: remove error reporting from qemu_fopen_bdrv() callers |
Date: |
Thu, 4 Feb 2021 17:18:55 +0000 |
This method cannot fail since it merely allocates a single struct, so
the only possible failure (ENOMEM) will cause an abort() already.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
migration/savevm.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index c18b7e6033..6a7b930b1c 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2861,10 +2861,7 @@ bool save_snapshot(const char *name, bool overwrite,
const char *vmstate,
/* save the VM state */
f = qemu_fopen_bdrv(bs, 1);
- if (!f) {
- error_setg(errp, "Could not open VM state file");
- goto the_end;
- }
+
ret = qemu_savevm_state(f, errp);
vm_state_size = qemu_ftell(f);
ret2 = qemu_fclose(f);
@@ -3041,10 +3038,6 @@ bool load_snapshot(const char *name, const char *vmstate,
/* restore the VM state */
f = qemu_fopen_bdrv(bs_vm_state, 0);
- if (!f) {
- error_setg(errp, "Could not open VM state file");
- goto err_drain;
- }
qemu_system_reset(SHUTDOWN_CAUSE_NONE);
mis->from_src_file = f;
--
2.29.2
- Re: [PATCH 12/33] migration: push Error **errp into loadvm_postcopy_handle_listen(), (continued)
- [PATCH 15/33] migration: make loadvm_postcopy_handle_resume() void, Daniel P . Berrangé, 2021/02/04
- [PATCH 14/33] migration: push Error **errp into loadvm_postcopy_ram_handle_discard(), Daniel P . Berrangé, 2021/02/04
- [PATCH 16/33] migration: push Error **errp into loadvm_handle_recv_bitmap(), Daniel P . Berrangé, 2021/02/04
- [PATCH 17/33] migration: push Error **errp into loadvm_process_enable_colo(), Daniel P . Berrangé, 2021/02/04
- [PATCH 18/33] migration: push Error **errp into colo_init_ram_cache(), Daniel P . Berrangé, 2021/02/04
- [PATCH 23/33] migration: simplify some error reporting in save_snapshot(), Daniel P . Berrangé, 2021/02/04
- [PATCH 19/33] migration: push Error **errp into check_section_footer(), Daniel P . Berrangé, 2021/02/04
- [PATCH 21/33] migration: remove error reporting from qemu_fopen_bdrv() callers,
Daniel P . Berrangé <=
- [PATCH 20/33] migration: push Error **errp into global_state_store(), Daniel P . Berrangé, 2021/02/04
- [PATCH 25/33] migration: push Error **errp into qemu_savevm_state_complete_precopy(), Daniel P . Berrangé, 2021/02/04
- [PATCH 22/33] migration: push Error **errp into qemu_savevm_state_iterate(), Daniel P . Berrangé, 2021/02/04
- [PATCH 28/33] migration: push Error **errp into qemu_savevm_send_packaged(), Daniel P . Berrangé, 2021/02/04
- [PATCH 31/33] migration: push Error **errp into qemu_savevm_state_resume_prepare(), Daniel P . Berrangé, 2021/02/04
- [PATCH 26/33] migration: push Error **errp into qemu_savevm_state_complete_precopy_non_iterable(), Daniel P . Berrangé, 2021/02/04
- [PATCH 32/33] migration: push Error **errp into postcopy_resume_handshake(), Daniel P . Berrangé, 2021/02/04
- [PATCH 27/33] migration: push Error **errp into qemu_savevm_state_complete_precopy(), Daniel P . Berrangé, 2021/02/04
- [PATCH 24/33] migration: push Error **errp into qemu_savevm_state_setup(), Daniel P . Berrangé, 2021/02/04
- [PATCH 29/33] migration: push Error **errp into qemu_savevm_live_state(), Daniel P . Berrangé, 2021/02/04