[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2]

From: John Snow
Subject: Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)
Date: Thu, 4 Feb 2021 15:57:58 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 2/4/21 9:22 AM, Wainer dos Santos Moschetta wrote:

On 2/4/21 10:59 AM, Philippe Mathieu-Daudé wrote:
On 2/4/21 2:54 PM, Wainer dos Santos Moschetta wrote:
The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, and virtiofsd.rst manuals were moved to docs/tools, so this update MAINTAINERS

Fixes: a08b4a9fe6c ("docs: Move tools documentation to tools manual")
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
v1: was "MAINTAINERS: Fix the location of virtiofsd.rst"
v2: Fixed the location of all files [philmd]

  MAINTAINERS | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

index 00626941f1..174425a941 100644
@@ -1829,7 +1829,7 @@ S: Odd Fixes
  F: hw/9pfs/
  X: hw/9pfs/xen-9p*
  F: fsdev/
-F: docs/interop/virtfs-proxy-helper.rst
+F: docs/tools/virtfs-proxy-helper.rst
Unrelated, but Paolo once said helpers are not tools.

Unrelated too, but allow me to ask:

Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to the tools directory (virtiofsd seems to feel alone there)?

Only smiles and cheers from me. I recommend a README.rst that can go in the tools/ directory that explains the purpose of the directory and standards for inclusion, etc.

Very small blurbs explaining what, broadly, the tools are, could be nice for passers-by on gitlab while browsing the source structure.

This would allow us to codify much of what happened later in this thread (what goes here, why? do we support it? etc.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]