Re: [PATCH v7 01/14] block: return status from bdrv

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 01/14] block: return status from bdrv_append and friends

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH v7 01/14] block: return status from bdrv_append and friends
Date:	Fri, 5 Feb 2021 14:26:25 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

05.02.2021 14:16, Alberto Garcia wrote:

On Tue 02 Feb 2021 01:49:43 PM CET, Vladimir Sementsov-Ogievskiy wrote:

The recommended use of qemu error api assumes returning status together
with setting errp and avoid void functions with errp parameter. Let's
improve bdrv_append and some friends to reduce error-propagation
overhead in further patches.

Choose int return status, because bdrv_replace_node_common() has call
to bdrv_check_update_perm(), which reports int status, which seems
correct to propagate.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>


I had already reviewed this one, hadn't I?

Reviewed-by: Alberto Garcia <berto@igalia.com>


Oh right, sorry.

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v7 00/14] block: deal with errp: part I, Vladimir Sementsov-Ogievskiy, 2021/02/02
- [PATCH v7 01/14] block: return status from bdrv_append and friends, Vladimir Sementsov-Ogievskiy, 2021/02/02
  - Re: [PATCH v7 01/14] block: return status from bdrv_append and friends, Alberto Garcia, 2021/02/05
    - Re: [PATCH v7 01/14] block: return status from bdrv_append and friends, Vladimir Sementsov-Ogievskiy <=
- [PATCH v7 04/14] blockdev: fix drive_backup_prepare() missed error, Vladimir Sementsov-Ogievskiy, 2021/02/02
- [PATCH v7 05/14] block: drop extra error propagation for bdrv_set_backing_hd, Vladimir Sementsov-Ogievskiy, 2021/02/02
- [PATCH v7 02/14] block: use return status of bdrv_append(), Vladimir Sementsov-Ogievskiy, 2021/02/02
- [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation, Vladimir Sementsov-Ogievskiy, 2021/02/02
  - Re: [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation, Eric Blake, 2021/02/12
    - Re: [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation, Kevin Wolf, 2021/02/15
    - Re: [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation, Eric Blake, 2021/02/15
    - Re: [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation, Vladimir Sementsov-Ogievskiy, 2021/02/16
    - Re: [PATCH v7 03/14] block: check return value of bdrv_open_child and drop error propagation, Kevin Wolf, 2021/02/16
- [PATCH v7 10/14] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps, Vladimir Sementsov-Ogievskiy, 2021/02/02

Prev by Date: Re: [PATCH] iotests: 30: drop from auto group (and effectively from make check)
Next by Date: Re: [PATCH 1/3] utils: Improve qemu_strtosz() to have 64 bits of precision
Previous by thread: Re: [PATCH v7 01/14] block: return status from bdrv_append and friends
Next by thread: [PATCH v7 04/14] blockdev: fix drive_backup_prepare() missed error
Index(es):
- Date
- Thread