[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 21/23] accel: introduce new accessor functions
From: |
Richard Henderson |
Subject: |
Re: [PATCH v16 21/23] accel: introduce new accessor functions |
Date: |
Fri, 5 Feb 2021 10:14:39 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/4/21 6:39 AM, Claudio Fontana wrote:
> @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj)
> x86_cpu_load_model(cpu, xcc->model);
> }
>
> - /* if required, do the accelerator-specific cpu initialization */
> - if (cc->accel_cpu) {
> - cc->accel_cpu->cpu_instance_init(CPU(obj));
> - }
> + /* if required, do accelerator-specific cpu initializations */
> + accel_cpu_instance_init(CPU(obj));
> }
Why is this only done for x86?
r~
- [PATCH v16 09/23] cpu: move cc->do_interrupt to tcg_ops, (continued)
- [PATCH v16 09/23] cpu: move cc->do_interrupt to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 10/23] cpu: move cc->transaction_failed to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 13/23] cpu: move adjust_watchpoint_address to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 11/23] cpu: move do_unaligned_access to tcg_ops, Claudio Fontana, 2021/02/04
- [PATCH v16 12/23] physmem: make watchpoint checking code TCG-only, Claudio Fontana, 2021/02/04
- [PATCH v16 16/23] accel: extend AccelState and AccelClass to user-mode, Claudio Fontana, 2021/02/04
- [PATCH v16 20/23] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2021/02/04
- [PATCH v16 22/23] target/i386: fix host_cpu_adjust_phys_bits error handling, Claudio Fontana, 2021/02/04
- [PATCH v16 21/23] accel: introduce new accessor functions, Claudio Fontana, 2021/02/04
- Re: [PATCH v16 21/23] accel: introduce new accessor functions,
Richard Henderson <=
[PATCH v16 18/23] accel: introduce AccelCPUClass extending CPUClass, Claudio Fontana, 2021/02/04
[PATCH v16 14/23] cpu: move debug_check_watchpoint to tcg_ops, Claudio Fontana, 2021/02/04
[PATCH v16 15/23] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass, Claudio Fontana, 2021/02/04
[PATCH v16 17/23] accel: replace struct CpusAccel with AccelOpsClass, Claudio Fontana, 2021/02/04
[PATCH v16 19/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass, Claudio Fontana, 2021/02/04