[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be cha
Michael S. Tsirkin
Re: [PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be changed
Sun, 7 Feb 2021 13:43:01 -0500
On Sun, Feb 07, 2021 at 08:23:33PM +0200, Marian Postevca wrote:
> "Michael S. Tsirkin" <firstname.lastname@example.org> writes:
> > I queued this but there's a lot of code duplication with this.
> > Further, the use of g_strdup adds unnecessary dynamic memory
> > management where it's not needed.
> > I'd prefer
> > - a new struct AcpiBuildOem including the correct strings
> > - use sizeof of fields in above instead of 8/6
> > - move shared strings and code into a common header
> So how should I approach this since the patches are queued? A new patch
> with the suggested changes, or resending the original patches?
A patch on top please. They are merged so really easy, just basing on
masted should be good.