[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 0/6] exec: Remove "tcg/tcg.h" from "exec/cpu_ldst.h"
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH v2 0/6] exec: Remove "tcg/tcg.h" from "exec/cpu_ldst.h" |
Date: |
Mon, 8 Feb 2021 00:23:04 +0100 |
Since v1:
- Do not move tlb_vaddr_to_host()
Hi,
I wondered why changing something in "tcg/tcg.h" would trigger
rebuilding the whole tree and figured the inclusion in
"exec/cpu_ldst.h".
By making tlb_addr_write() static to accel/tcg/cputlb.c we can
remove the "tcg/tcg.h" inclusion and reduce the number of objects
to rebuild.
I added tlb_assert_iotlb_entry_for_ptr_present() but there is
this comment in target/arm/mte_helper.c which I don't understand
much (so have no clue how to fix this TODO) but I suppose this
would be to add a proper implementation and not need this ugly
tlb_assert_iotlb_entry_for_ptr_present():
* TODO: Perhaps there should be a cputlb helper that returns a
* matching tlb entry + iotlb entry.
Regards,
Phil.
Philippe Mathieu-Daudé (6):
target: Replace tcg_debug_assert() by assert()
target/m68k: Include missing "tcg/tcg.h" header
target/mips: Include missing "tcg/tcg.h" header
accel/tcg: Include missing "tcg/tcg.h" header
accel/tcg: Refactor debugging tlb_assert_iotlb_entry_for_ptr_present()
exec/cpu_ldst: Move tlb* declarations to "exec/exec-all.h"
include/exec/cpu_ldst.h | 28 -------------------
include/exec/exec-all.h | 25 +++++++++++++++++
target/arm/translate.h | 4 +--
accel/tcg/cputlb.c | 23 ++++++++++++++++
accel/tcg/tcg-accel-ops-mttcg.c | 1 +
accel/tcg/tcg-accel-ops-rr.c | 1 +
target/arm/mte_helper.c | 15 +++--------
target/arm/sve_helper.c | 18 +++++--------
target/arm/translate-a64.c | 12 ++++-----
target/arm/translate-sve.c | 4 +--
target/arm/translate.c | 36 ++++++++++++-------------
target/hppa/translate.c | 4 +--
target/m68k/op_helper.c | 1 +
target/mips/msa_helper.c | 1 +
target/rx/op_helper.c | 6 ++---
target/rx/translate.c | 14 +++++-----
target/sh4/translate.c | 4 +--
target/riscv/insn_trans/trans_rvv.c.inc | 2 +-
18 files changed, 105 insertions(+), 94 deletions(-)
--
2.26.2
- [RFC PATCH v2 0/6] exec: Remove "tcg/tcg.h" from "exec/cpu_ldst.h",
Philippe Mathieu-Daudé <=
- [RFC PATCH v2 1/6] target: Replace tcg_debug_assert() by assert(), Philippe Mathieu-Daudé, 2021/02/07
- [PATCH v2 3/6] target/mips: Include missing "tcg/tcg.h" header, Philippe Mathieu-Daudé, 2021/02/07
- [PATCH v2 2/6] target/m68k: Include missing "tcg/tcg.h" header, Philippe Mathieu-Daudé, 2021/02/07
- [PATCH v2 4/6] accel/tcg: Include missing "tcg/tcg.h" header, Philippe Mathieu-Daudé, 2021/02/07
- [RFC PATCH v2 5/6] accel/tcg: Refactor debugging tlb_assert_iotlb_entry_for_ptr_present(), Philippe Mathieu-Daudé, 2021/02/07