Re: [PATCH] migration: Drop unused VMSTATE_FLOAT64 support

[Philippe Mathieu-Daudé]

+Eduardo/Richard.

On 2/7/21 8:43 PM, Peter Maydell wrote:
> On Sun, 7 Feb 2021 at 17:10, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> On 10/22/20 2:08 PM, Peter Maydell wrote:
>>> Commit ef96e3ae9698d6 in January 2019 removed the last user of the
>>> VMSTATE_FLOAT64* macros. These were used by targets which defined
>>> their floating point register file as an array of 'float64'.
>>
>> Similar candidate: VMSTATE_CPUDOUBLE_ARRAY()
> 
> Isn't that still used by target/sparc ?

Sorry, I meant CPU_DoubleU could be a similar to the removal of float64
in commit ef96e3ae969 ("target/ppc: move FP and VMX registers into
aligned vsr register array"), so we can remove VMSTATE_CPUDOUBLE_ARRAY()
later.

But I could be wrong and this is a legit use, as CPU_DoubleU contains
either a float64 or a uint64_t.

Now if the CPU_DoubleU/CPU_QuadU unions are only meant for CPU
registers, we should either document that or better move these
declarations out of the generic "qemu/bswap.h" ("exec/cpu-defs.h"
looks like a good candidate).

> 
> -- PMM
>