[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment

From: schspa
Subject: Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment
Date: Mon, 08 Feb 2021 13:34:02 +0800
User-agent: Evolution 3.38.3

On Fri, 2021-02-05 at 15:08 +0100, Edgar E. Iglesias wrote:
> Thanks, that matches how I thought things should work.
> I wonder if virtio_mmio_bus_get_dev_path() really should be peeking
> into
> Sysbus internals mmio[].addr?
I think mmio[].addr needs to be given a meaningful value even if we
don't use it.

> Sysbus mmio[].addr looks like a candidate for removal if we ever get
> rid
> of the default system_memory...
> I don't have any good suggestions how to fix this. I guess we could
> wrap
> memory_region_add_subregion() with a sysbus version of it that sets
> mmio[].addr but that seems like a step backwards to me.
> Perhaps there's a way fix this in virtio_mmio_bus_get_dev_path()?

I think we can change virtio_mmio_bus_get_dev_path() with the following

   add a prop to specify a unique device_path for virtio_mmio TypeInfo.
   add a global static instance count to generate a unique device path.

schspa <schspa@gmail.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]