[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/6] hw/arm: Add I2C sensors and EEPROM for GSJ machine
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 4/6] hw/arm: Add I2C sensors and EEPROM for GSJ machine |
Date: |
Mon, 8 Feb 2021 16:51:15 +0000 |
On Fri, 29 Jan 2021 at 01:04, Hao Wu <wuhaotsh@google.com> wrote:
>
> Add AT24 EEPROM and temperature sensors for GSJ machine.
>
> Reviewed-by: Doug Evans<dje@google.com>
> Reviewed-by: Tyrong Ting<kfting@nuvoton.com>
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> ---
> default-configs/devices/arm-softmmu.mak | 1 +
> hw/arm/npcm7xx_boards.c | 27 +++++++++++++++++++++++++
> 2 files changed, 28 insertions(+)
>
> diff --git a/default-configs/devices/arm-softmmu.mak
> b/default-configs/devices/arm-softmmu.mak
> index 0500156a0c..d9805dd539 100644
> --- a/default-configs/devices/arm-softmmu.mak
> +++ b/default-configs/devices/arm-softmmu.mak
> @@ -7,6 +7,7 @@ CONFIG_ARM_V7M=y
> # CONFIG_TEST_DEVICES=n
>
> CONFIG_ARM_VIRT=y
> +CONFIG_AT24C=y
> CONFIG_CUBIEBOARD=y
> CONFIG_EXYNOS4=y
> CONFIG_HIGHBANK=y
Rather than adding this here, you should "select AT24C" in
the "config NPCM7XX' section of hw/arm/Kconfig.
> + /* TODO: Add addtional i2c devices. */
"additional"
> +}
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 4/6] hw/arm: Add I2C sensors and EEPROM for GSJ machine,
Peter Maydell <=