[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/15] tcg: Change parameters for tcg_target_const_match
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 01/15] tcg: Change parameters for tcg_target_const_match |
Date: |
Mon, 8 Feb 2021 17:43:52 +0000 |
On Mon, 8 Feb 2021 at 03:31, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Change the return value to bool, because that's what is should
> have been from the start. Pass the ct mask instead of the whole
> TCGArgConstraint, as that's the only part that's relevant.
>
> Change the value argument to int64_t. We will need the extra
> width for 32-bit hosts wanting to match vector constants.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tcg.c | 5 ++---
> tcg/aarch64/tcg-target.c.inc | 5 +----
> tcg/arm/tcg-target.c.inc | 5 +----
> tcg/i386/tcg-target.c.inc | 4 +---
> tcg/mips/tcg-target.c.inc | 5 +----
> tcg/ppc/tcg-target.c.inc | 4 +---
> tcg/riscv/tcg-target.c.inc | 4 +---
> tcg/s390/tcg-target.c.inc | 5 +----
> tcg/sparc/tcg-target.c.inc | 5 +----
> tcg/tci/tcg-target.c.inc | 6 ++----
> 10 files changed, 12 insertions(+), 36 deletions(-)
>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
[PATCH v2 03/15] tcg/arm: Implement tcg_out_ld/st for vector types, Richard Henderson, 2021/02/07
[PATCH v2 04/15] tcg/arm: Implement tcg_out_mov for vector types, Richard Henderson, 2021/02/07