[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] accel/tcg: Add URL of clang bug to comment about our workaro

From: Peter Maydell
Subject: Re: [PATCH] accel/tcg: Add URL of clang bug to comment about our workaround
Date: Tue, 9 Feb 2021 10:20:59 +0000

On Fri, 29 Jan 2021 at 15:19, Alex Bennée <alex.bennee@linaro.org> wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
> > In cpu_exec() we have a longstanding workaround for compilers which
> > do not correctly implement the part of the sigsetjmp()/siglongjmp()
> > spec which requires that local variables which are not changed
> > between the setjmp and the longjmp retain their value.
> >
> > I recently ran across the upstream clang bug report for this; add a
> > link to it to the comment describing the workaround, and generally
> > expand the comment, so that we have a reasonable chance in future of
> > understanding why it's there and determining when we can remove it,
> > assuming clang eventually fixes the bug.
> >
> > Remove the /* buggy compiler */ comments on the #else and #endif:
> > they don't add anything to understanding and are somewhat misleading
> > since they're sandwiching the code path for *non*-buggy compilers.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Thanks. I'll put this in via target-arm.next unless somebody
has a preference for it going in via some other tree ?

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]