Re: [PATCH 0/6] m68k: Overhaul of MOVEC instruction to support exception/MSP

[BALATON Zoltan]

On Mon, 1 Feb 2021, BALATON Zoltan wrote:
> Hello,
>
> This is Lucien's m68k series rebased on and fixed up to work with
> current master as per previous discussion:
> https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html
>
> I've left previous Reviewed-by tags for reference but these should
> probably be reviewed again. I've only lightly tested it so I don't
> know if everything is correct but it does seem to fix the problem my
> original patch tried to fix at least. More testing, review and help to
> finish this so it can be merged at last is welcome.

Ping?

> Regards,
> BALATON Zoltan
>
> Lucien Murray-Pitts (6):
>  m68k: improve cpu instantiation comments
>  m68k: cascade m68k_features by m680xx_cpu_initfn() to improve
>    readability
>  m68k: improve comments on m68k_move_to/from helpers
>  m68k: add missing BUSCR/PCR CR defines, and BUSCR/PCR/CAAR CR to
>    m68k_move_to/from
>  m68k: MOVEC insn. should generate exception if wrong CR is accessed
>  m68k: add MSP detection support for stack pointer swap helpers
>
> target/m68k/cpu.c       | 116 ++++++++++++++------
> target/m68k/cpu.h       |  64 +++++++----
> target/m68k/helper.c    | 234 +++++++++++++++++++++++++++++++---------
> target/m68k/translate.c |   2 +-
> 4 files changed, 309 insertions(+), 107 deletions(-)